fix: rename roles to use underscores instead of hyphens which was causing the roles not to be found

README.md

@@ -4,14 +4,14 @@ Ansible collection for infrastructure management, system configuration, and virt
 
 ## Roles
 
-### proxmox-lxc-provision
+### proxmox_lxc_provision
 Manages Proxmox LXC containers with comprehensive lifecycle operations.
 
 - Create, clone, start, stop, and delete containers
 - Template conversion and configuration editing
 - Post-provisioning tasks and health checks
 
-### system-setup
+### system_setup
 Performs initial system configuration for new servers.
 
 - Creates admin user with SSH key authentication
@@ -19,14 +19,14 @@ Performs initial system configuration for new servers.
 - Installs essential packages
 - Optional passwordless sudo configurations
 
-### system-maintenance
+### system_maintenance
 Updates packages and handles maintenance across multiple distributions.
 
 - Multi-distribution support (Debian/Ubuntu/Alpine)
 - Package updates and cleanup
 - Automatic reboot handling when required
 
-### nvidia-drivers
+### nvidia_drivers
 Installs NVIDIA drivers and CUDA runtime with proper idempotency and error handling.
 
 - Supports Debian/Ubuntu with automatic OS detection
@@ -53,7 +53,7 @@ ansible-galaxy collection install patrickj.infrastructure
     - os_template: "local:vztmpl/debian-12_amd64.tar.zst"
     - container_ipv4: "10.0.0.99"
   roles:
-    - role: proxmox-provision
+    - role: proxmox_lxc_provision
 
 - name: Configure the LXC container
   hosts: new-debian-container

roles/nvidia_drivers/README.md

@@ -27,7 +27,7 @@ Installs NVIDIA drivers and CUDA runtime on Debian/Ubuntu systems with proper id
 ```yaml
 - name: Install NVIDIA drivers with kernel modules
   include_role:
-    name: nvidia-drivers
+    name: nvidia_drivers
   vars:
     nvidia_install_kernel_modules: true
     nvidia_open_source_drivers: false
@@ -37,7 +37,7 @@ Installs NVIDIA drivers and CUDA runtime on Debian/Ubuntu systems with proper id
 ```yaml
 - name: Install NVIDIA userspace libraries
   include_role:
-    name: nvidia-drivers
+    name: nvidia_drivers
   vars:
     nvidia_install_kernel_modules: false
 ```
@@ -46,7 +46,7 @@ Installs NVIDIA drivers and CUDA runtime on Debian/Ubuntu systems with proper id
 ```yaml
 - name: Install NVIDIA with extras
   include_role:
-    name: nvidia-drivers
+    name: nvidia_drivers
   vars:
     nvidia_install_kernel_modules: true
     nvidia_optional_packages:

roles/proxmox_lxc_provision/README.md

@@ -1,19 +1,19 @@
-# Ansible Role: proxmox-lxc-provision
+# Ansible Role: proxmox_lxc_provision
 
 ## Description
 
 This Ansible role manages the provision of LXC containers and templates on a Proxmox host. By default the role will create and start an LXC container. It allows creating a new container from a [container image](https://pve.proxmox.com/wiki/Linux_Container#pct_container_images) or cloning an existing container or template container.
 
 It also includes tasks which may be used individually:
-- `clone.yaml`: Creates a new LXC container by cloning another container or template
+- `clone.yml`: Creates a new LXC container by cloning another container or template
-- `convert.yaml`: Converts an LXC container to a template
+- `convert.yml`: Converts an LXC container to a template
-- `create.yaml`: Creates a new LXC container
+- `create.yml`: Creates a new LXC container
-- `delete.yaml`: Deletes an LXC container given its vmid or hostname
+- `delete.yml`: Deletes an LXC container given its vmid or hostname
-- `start.yaml`: Starts an LXC container
+- `start.yml`: Starts an LXC container
-- `stop.yaml`: Stops an LXC container
+- `stop.yml`: Stops an LXC container
-- `update.yaml`: Updates an existing LXC container
+- `update.yml`: Updates an existing LXC container
-- `wait.yaml`: Waits for SSH to be available on the container
+- `wait.yml`: Waits for SSH to be available on the container
-
+- `check-exists.yml`: Checks the existence of the LXC with the given hostname
 ## Requirements
 
 - Ansible 2.9 or higher
@@ -103,7 +103,7 @@ proxmox_node: "pve01"
     lxc_template: "local:vztmpl/debian-12_amd64.tar.zst"
     lxc_ipv4: "10.0.0.99"
   roles:
-    - role: proxmox-lxc-provision
+    - role: proxmox_lxc_provision
 ```
 
 ### Creating a new LXC by cloning an existing container with vmid 200
@@ -116,7 +116,7 @@ proxmox_node: "pve01"
     lxc_clone_from: 200
     lxc_ipv4: "10.0.0.99"
   roles:
-    - role: proxmox-lxc-provision
+    - role: proxmox_lxc_provision
 ```
 
 ### Idempotent Behavior
@@ -135,7 +135,7 @@ The role now includes idempotency checking. If a container with the specified `c
     - os_template: "local:vztmpl/debian-12_amd64.tar.zst"
     - container_ipv4: "10.0.0.99"
   roles:
-    - role: proxmox-lxc-provision
+    - role: proxmox_lxc_provision
 
 # Run configuration tasks on the container
 # ...
@@ -146,6 +146,6 @@ The role now includes idempotency checking. If a container with the specified `c
     container_hostname: "{{ container_hostname }}"
   tasks:
     - include_role:
-        name: proxmox-lxc-provision
+        name: proxmox_lxc_provision
         tasks_from: convert
 ```

roles/proxmox_lxc_provision/tasks/post-clone.yml

@@ -15,7 +15,7 @@
 
 - name: Regenerate SSH host keys
   ansible.builtin.include_role:
-    name: system-setup
+    name: system_setup
     tasks_from: ssh
   vars:
     regenerate_ssh_keys: true

roles/system_maintenance/README.md

@@ -20,7 +20,7 @@ Updates packages and handles system maintenance tasks across multiple distributi
 ```yaml
 - name: Perform system maintenance
   include_role:
-    name: system-maintenance
+    name: system_maintenance
 ```
 
 ## What It Does

roles/system_setup/README.md

@@ -9,7 +9,7 @@ Performs initial system configuration including user creation, SSH hardening, an
 - Installs essential packages
 - Optional passwordless sudo
 - Optional SSH host key regeneration
-- System package updates (via system-maintenance role)
+- System package updates (via system_maintenance role)
 
 ## Variables
 
@@ -38,7 +38,7 @@ ssh_pubkey_file: "/path/to/your/public/key.pub"
 ```yaml
 - name: Initial system setup
   include_role:
-    name: system-setup
+    name: system_setup
   vars:
     password: "{{ admin_password }}"
     ssh_pubkey_file: "~/.ssh/id_rsa.pub"
@@ -48,7 +48,7 @@ ssh_pubkey_file: "/path/to/your/public/key.pub"
 ```yaml
 - name: System setup with custom user
   include_role:
-    name: system-setup
+    name: system_setup
   vars:
     username: myuser
     password: "{{ user_password }}"
@@ -65,7 +65,7 @@ ssh_pubkey_file: "/path/to/your/public/key.pub"
 
 ## What It Does
 
-1. **System Updates** - Calls system-maintenance role for package updates
+1. **System Updates** - Calls system_maintenance role for package updates
 2. **Package Installation** - Installs packages from `extra_packages` list
 3. **User Creation** - Creates user with password and sudo access
 4. **SSH Key Setup** - Configures authorized keys for the user
@@ -76,7 +76,7 @@ ssh_pubkey_file: "/path/to/your/public/key.pub"
 
 - Root privileges
 - SSH public key file accessible to Ansible
-- system-maintenance role (dependency)
+- system_maintenance role (dependency)
 
 ## Security Notes
 

roles/system_setup/tasks/main.yml

@@ -2,7 +2,7 @@
 
 # Upgrade and update packages
 - include_role: 
-    name: system-maintenance
+    name: system_maintenance
 
 # Install extra packages
 - include_tasks: extra-packages.yaml