refactor(proxmox_lxc_provision): centralize module_defaults so tasks_from works without setup

Previously the community.proxmox.proxmox / proxmox_vm_info module_defaults
were defined inline on the outer block in main.yml. Invoking individual
task files via 'tasks_from: stop' (or delete/convert/etc.) bypassed
main.yml, leaving the API parameters unset and producing
'missing required arguments: api_host, api_user' errors. The README
worked around this by telling callers to repeat the module_defaults
block at the play level — easy to forget, and duplicated config.

Extract the defaults dict into _proxmox_module_defaults in
defaults/main.yml (using a YAML anchor to share between the two
modules), and wrap every task file that calls a Proxmox module in a
block that references it. Callers only need the proxmox_* connection
vars in scope (typically group_vars/all/) — both 'roles:' and
'tasks_from:' invocations now configure the API consistently.

Files wrapped: check-exists, create, clone, update, start, stop,
delete, convert. wait/post-clone/edit-config don't call Proxmox modules
and are unchanged. main.yml's now-redundant outer module_defaults is
removed.

README updated to drop the 'Using Standalone Tasks' workaround
boilerplate.

roles/proxmox_lxc_provision/README.md

@@ -144,26 +144,17 @@ The role includes idempotency checking. If a container with the specified `lxc_v
 
 ### Using Standalone Tasks
 
-When using individual task files via `tasks_from`, you must set `module_defaults` at the play level since the tasks bypass the role's main entry point:
+Individual task files (`stop`, `start`, `delete`, `convert`, etc.) can be invoked via `tasks_from` directly — each task file wraps its work in a block with the role's shared `module_defaults`, so the Proxmox API connection is configured automatically as long as the `proxmox_*` connection variables are in scope (typically from `group_vars/all/`).
 
 ```yaml
 - name: Convert container to a template
   hosts: localhost
-  module_defaults:
-    community.proxmox.proxmox:
-      api_host: "{{ proxmox_api_host }}"
-      api_port: "{{ proxmox_api_port }}"
-      api_user: "{{ proxmox_api_user }}"
-      api_token_id: "{{ proxmox_api_token_id }}"
-      api_token_secret: "{{ proxmox_api_token_secret }}"
-      validate_certs: "{{ proxmox_api_validate_certs }}"
-      node: "{{ proxmox_node }}"
-  vars:
-    lxc_hostname: "{{ lxc_hostname }}"
   tasks:
     - include_role:
         name: proxmox_lxc_provision
         tasks_from: convert
+      vars:
+        lxc_hostname: my-container
 ```
 
 ### Creating an LXC Container and Converting it to a Template
@@ -185,19 +176,10 @@ When using individual task files via `tasks_from`, you must set `module_defaults
 
 - name: Convert the created container to a template
   hosts: localhost
-  module_defaults:
-    community.proxmox.proxmox:
-      api_host: "{{ proxmox_api_host }}"
-      api_port: "{{ proxmox_api_port }}"
-      api_user: "{{ proxmox_api_user }}"
-      api_token_id: "{{ proxmox_api_token_id }}"
-      api_token_secret: "{{ proxmox_api_token_secret }}"
-      validate_certs: "{{ proxmox_api_validate_certs }}"
-      node: "{{ proxmox_node }}"
-  vars:
-    lxc_hostname: "{{ lxc_hostname }}"
   tasks:
     - include_role:
         name: proxmox_lxc_provision
         tasks_from: convert
+      vars:
+        lxc_hostname: "{{ lxc_hostname }}"
 ```

roles/proxmox_lxc_provision/defaults/main.yml

@@ -5,6 +5,19 @@ proxmox_api_validate_certs: false
 # Host to delegate pct commands to (use inventory hostname for become_password to work)
 proxmox_delegate_host: "{{ proxmox_api_host }}"
 
+# Shared module_defaults applied by every task file that calls the Proxmox API.
+# Override the underlying proxmox_* vars (e.g. from group_vars/all/) to customize.
+_proxmox_module_defaults:
+  community.proxmox.proxmox: &_proxmox_api_args
+    api_host: "{{ proxmox_api_host }}"
+    api_port: "{{ proxmox_api_port }}"
+    api_user: "{{ proxmox_api_user }}"
+    api_token_id: "{{ proxmox_api_token_id }}"
+    api_token_secret: "{{ proxmox_api_token_secret }}"
+    validate_certs: "{{ proxmox_api_validate_certs }}"
+    node: "{{ proxmox_node }}"
+  community.proxmox.proxmox_vm_info: *_proxmox_api_args
+
 # LXC defaults
 lxc_template: "local:vztmpl/debian-12-standard_12.12-1_amd64.tar.zst"
 lxc_cores: 4

roles/proxmox_lxc_provision/tasks/check-exists.yml

@@ -1,10 +1,13 @@
 ---
-- name: Query Proxmox for existing LXCs
+- name: Check if LXC exists
+  module_defaults: "{{ _proxmox_module_defaults }}"
+  block:
+    - name: Query Proxmox for existing LXCs
       community.proxmox.proxmox_vm_info:
         type: lxc
       register: proxmox_lxcs
 
-- name: Check if LXC already exists
+    - name: Check if LXC already exists
       ansible.builtin.set_fact:
         lxc_exists: >-
           {{

roles/proxmox_lxc_provision/tasks/clone.yml

@@ -1,5 +1,8 @@
 ---
-- name: Create a full clone of the container
+- name: Clone LXC container
+  module_defaults: "{{ _proxmox_module_defaults }}"
+  block:
+    - name: Create a full clone of the container
       community.proxmox.proxmox:
         vmid: "{{ lxc_vmid | default(0) }}"
         clone: "{{ lxc_clone_from }}"
@@ -8,14 +11,14 @@
         storage: "{{ lxc_storage }}"
       register: clone_result
 
-- name: Add bind mounts via pct
+    - name: Add bind mounts via pct
       become: yes
       ansible.builtin.shell: |
         pct set {{ clone_result.vmid | default(lxc_vmid) }} {% for key, value in lxc_mounts.items() %}-{{ key }} {{ value }} {% endfor %}
       delegate_to: "{{ proxmox_delegate_host }}"
       when: lxc_mounts is defined
 
-- name: Resize rootfs after clone
+    - name: Resize rootfs after clone
       ansible.builtin.command:
         cmd: "pct resize {{ clone_result.vmid }} rootfs {{ lxc_size }}G"
       delegate_to: "{{ proxmox_delegate_host }}"

roles/proxmox_lxc_provision/tasks/convert.yml

@@ -1,7 +1,10 @@
 ---
-- ansible.builtin.include_tasks: stop.yml
+- name: Convert LXC container to template
+  module_defaults: "{{ _proxmox_module_defaults }}"
+  block:
+    - ansible.builtin.include_tasks: stop.yml
 
-- name: Convert container to template
+    - name: Convert container to template
       community.proxmox.proxmox:
         hostname: "{{ lxc_hostname }}"
         state: template

roles/proxmox_lxc_provision/tasks/create.yml

@@ -1,5 +1,8 @@
 ---
-- name: Create an LXC container
+- name: Create LXC container
+  module_defaults: "{{ _proxmox_module_defaults }}"
+  block:
+    - name: Create an LXC container
       community.proxmox.proxmox:
         vmid: "{{ lxc_vmid | default(omit) }}"
         hostname: "{{ lxc_hostname }}"

roles/proxmox_lxc_provision/tasks/delete.yml

@@ -1,7 +1,10 @@
 ---
-- ansible.builtin.include_tasks: stop.yml
+- name: Delete LXC container
+  module_defaults: "{{ _proxmox_module_defaults }}"
+  block:
+    - ansible.builtin.include_tasks: stop.yml
 
-- name: Delete a container
+    - name: Delete a container
       community.proxmox.proxmox:
         vmid: "{{ lxc_vmid | default(omit) }}"
         hostname: "{{ lxc_hostname | default(omit) }}"

roles/proxmox_lxc_provision/tasks/main.yml

@@ -1,30 +1,18 @@
 ---
-- name: Proxmox LXC provision
+- name: Check if container exists
-  module_defaults:
-    community.proxmox.proxmox: &proxmox_defaults
-      api_host: "{{ proxmox_api_host }}"
-      api_port: "{{ proxmox_api_port }}"
-      api_user: "{{ proxmox_api_user }}"
-      api_token_id: "{{ proxmox_api_token_id }}"
-      api_token_secret: "{{ proxmox_api_token_secret }}"
-      validate_certs: "{{ proxmox_api_validate_certs }}"
-      node: "{{ proxmox_node }}"
-    community.proxmox.proxmox_vm_info: *proxmox_defaults
-  block:
-    - name: Check if container exists
   ansible.builtin.include_tasks:
     file: check-exists.yml
 
-    - name: Skip if container already exists
+- name: Skip if container already exists
   meta: end_host
   when: lxc_exists | bool
 
-    - name: Container source must be defined (lxc_clone_from or lxc_template)
+- name: Container source must be defined (lxc_clone_from or lxc_template)
   ansible.builtin.fail:
     msg: "Neither lxc_clone_from or lxc_template are defined"
   when: lxc_clone_from is undefined and lxc_template is undefined
 
-    - name: Clone container from another container or template, then update
+- name: Clone container from another container or template, then update
   when: lxc_clone_from is defined
   block:
     - name: Clone from template
@@ -39,12 +27,12 @@
         lxc_vmid: "{{ clone_result.vmid }}"
       register: lxc_result
 
-    - name: Create the new container
+- name: Create the new container
   ansible.builtin.include_tasks:
     file: create.yml
   when: lxc_template is defined and lxc_clone_from is undefined
 
-    - name: Start the created container and wait for ssh
+- name: Start the created container and wait for ssh
   vars:
     lxc_vmid: "{{ lxc_result.vmid }}"
   ansible.builtin.include_tasks:
@@ -54,7 +42,7 @@
     - wait.yml
   when: lxc_start
 
-    - name: Post clone updates
+- name: Post clone updates
   when: lxc_clone_from is defined
   delegate_to: "{{ lxc_hostname }}"
   block:

roles/proxmox_lxc_provision/tasks/start.yml

@@ -1,5 +1,8 @@
 ---
-- name: Start the LXC container
+- name: Start LXC container
+  module_defaults: "{{ _proxmox_module_defaults }}"
+  block:
+    - name: Start the LXC container
       community.proxmox.proxmox:
         vmid: "{{ lxc_result.vmid }}"
         state: started

roles/proxmox_lxc_provision/tasks/stop.yml

@@ -1,5 +1,8 @@
 ---
-- name: Stop container if it is running
+- name: Stop LXC container
+  module_defaults: "{{ _proxmox_module_defaults }}"
+  block:
+    - name: Stop container if it is running
       community.proxmox.proxmox:
         vmid: "{{ lxc_vmid | default(omit) }}"
         hostname: "{{ lxc_hostname | default(omit) }}"

roles/proxmox_lxc_provision/tasks/update.yml

@@ -1,5 +1,8 @@
 ---
-- name: Update an LXC container
+- name: Update LXC container
+  module_defaults: "{{ _proxmox_module_defaults }}"
+  block:
+    - name: Update an LXC container
       community.proxmox.proxmox:
         vmid: "{{ lxc_vmid }}"
         hostname: "{{ lxc_hostname }}"