feat: lint and format tests in CI

Only src/ was covered, which is why it stayed clean while tests/ drifted to 38
findings. migrations/ stays out: its alembic template emits unused imports, so
every generated revision would fail the gate.

.gitea/workflows/ci.yml

@@ -2,10 +2,11 @@ name: ci
 
 # Formatting, linting, types and tests on every push and pull request.
 #
-# Blocking: the checks that are clean today — ruff format, ruff check, prettier, pytest.
+# Blocking: ruff format, ruff check, pytest, prettier and svelte-check.
-# Non-blocking: eslint and svelte-check, which still report 87 and 30 pre-existing errors.
+# Non-blocking: eslint, which reports two `{@html}` XSS findings in collapsible-text.svelte.
-# Those need real code changes rather than a formatter, so they report without failing the
+# Those are a real vulnerability rather than a lint nit — book descriptions from EPUB files
-# build; drop the `continue-on-error` line from a step once its count reaches zero.
+# are not sanitized — and fixing them is a backend change. Drop the `continue-on-error` once
+# that lands, at which point every check blocks.
 #
 # The release workflow runs the blocking half again before it publishes anything.
 
@@ -36,10 +37,10 @@ jobs:
         run: uv sync --locked
 
       - name: Format
-        run: uv run ruff format --check src/
+        run: uv run ruff format --check src/ tests/
 
       - name: Lint
-        run: uv run ruff check src/
+        run: uv run ruff check src/ tests/
 
       # pytest-databases starts a throwaway PostgreSQL container, so this needs a working
       # Docker daemon on the runner — the same requirement the release workflow has.
@@ -77,4 +78,3 @@ jobs:
 
       - name: Types
         run: pnpm check
-        continue-on-error: true

.gitea/workflows/release.yml

@@ -42,20 +42,21 @@ jobs:
         working-directory: backend
         run: |
           uv sync --locked
-          uv run ruff format --check src/
+          uv run ruff format --check src/ tests/
-          uv run ruff check src/
+          uv run ruff check src/ tests/
           uv run pytest tests/ -q
 
       - uses: actions/setup-node@v4
         with:
           node-version: 24
 
-      - name: Frontend format
+      - name: Frontend format and types
         working-directory: frontend
         run: |
           corepack enable
           pnpm install --frozen-lockfile
           pnpm exec prettier --check .
+          pnpm check
 
   build:
     needs: quality

AGENTS.md

@@ -70,7 +70,7 @@ Backend (from `backend/`):
 ```bash
 uv run litestar --app-dir src/chitai/ run --reload   # dev server on :8000
 pytest tests/                                        # needs Docker (pytest-databases)
-ruff format src/
+ruff format src/ tests/
 alchemy --config chitai.database.config.config make-migrations
 alchemy --config chitai.database.config.config upgrade
 
@@ -103,9 +103,11 @@ API docs are served by the running backend at `http://localhost:8000/schema/` (S
   manually against a live backend).
 - **Migrations are mandatory.** The app runs with `create_all=False`, so a model change without a
   matching Alembic revision will not reach the database.
-- **CI gates formatting, linting and tests.** `.gitea/workflows/ci.yml` runs on every push and pull
+- **CI gates formatting, linting, types and tests.** `.gitea/workflows/ci.yml` runs on every push
-  request: `ruff format --check`, `ruff check`, `pytest`, and `prettier --check` all **block**;
+  and pull request: `ruff format --check src/ tests/`, `ruff check src/ tests/`, `pytest`,
-  `eslint` and `pnpm check` report without failing until their pre-existing counts reach zero. A
+  `prettier --check` and `pnpm check` all **block**; only `eslint` reports without failing, and
+  only until the two `{@html}` findings in `TODO.md` are fixed. Ruff covers `src/` and `tests/`
+  but deliberately not `migrations/`, whose alembic template emits imports it does not use. A
   `v*` tag additionally builds and publishes both container images — see
   `docs/ci-release-pipeline.md`.
 - **Commit messages** follow `type: summary` — `feat:`, `fix:`, `refactor:`, `chore:`.

TODO.md

@@ -114,6 +114,24 @@ CMD ["litestar", "--app-dir", "chitai", "run", "--host", "0.0.0.0", "--port", "8
 `litestar run` is the CLI development runner. Production should invoke uvicorn or granian
 directly, with a worker count.
 
+### The delete_files flag is untested in both directions
+
+`backend/tests/integration/test_book.py` — `test_remove_file_with_delete_files_false_keeps_filesystem_file`
+and `test_remove_file_with_delete_files_true_removes_filesystem_file`
+
+Both tests capture the file's path and then assert only `response.status_code == 204`.
+Neither looks at the disk. So the flag that decides whether removing a file from a book
+also **erases it from the filesystem** is covered in name only, in both directions.
+
+Ruff surfaced this as two `F841` unused variables; the variables carry a `# noqa: F841`
+and a comment rather than being deleted, so the gap stays visible. Remove the noqa when
+the assertions land.
+
+The reason it is not a two-line fix: `FileMetadata.path` is stored relative to `book.path`,
+so the test has to resolve it against the library root to know what to stat. That
+resolution is the same thing `BookService.get_files` is recorded as getting wrong (see
+`backend/AGENTS.md`), so it is worth settling once and using in both places.
+
 ### No type checker on the backend
 
 Formatting, linting and tests now run in CI (`.gitea/workflows/ci.yml`) and block, and the
@@ -126,6 +144,35 @@ that set is worthwhile and will surface a fresh batch of findings.
 
 ## Frontend
 
+### Book descriptions are rendered as unsanitized HTML
+
+`frontend/src/lib/components/ui/collapsible-text/collapsible-text.svelte` — lines 42 and 45
+
+The component renders `{@html text}`, and its only caller is the book detail page:
+`<CollapsibleText text={book.description} maxLength={500} />`. So whatever is in
+`Book.description` reaches the DOM as markup.
+
+The Calibre importer is fine — `services/calibre.py:401` passes comments through
+`strip_html`, because Calibre stores HTML there. But `strip_html` is used **nowhere else in
+the backend**, and `EpubExtractor._extract_description` returns
+`epub.get_metadata("DC", "description")[0][0]` verbatim. EPUB `dc:description` routinely
+carries markup, so an uploaded book with `<img src=x onerror=…>` in that field executes
+script on the book page, with the session cookie in scope. Metadata edited through the UI
+is stored unfiltered too.
+
+This is the same class as the scripted-EPUB item below — untrusted file content reaching an
+origin that holds a session — by a different route, and it does not need `allow-scripts` to
+work.
+
+Fix: sanitize at ingest, next to where Calibre already does. Reuse `strip_html` in
+`_extract_description` if descriptions should be plain text, or run an allowlist sanitizer if
+the formatting is worth keeping. Either way the stored rows need backfilling through the same
+helper, since the validators only fire on write. Dropping `{@html}` to `{text}` in the
+component fixes the display side but leaves the payload in the database.
+
+These are the only two findings `pnpm exec eslint .` still reports; CI's eslint step stops
+being `continue-on-error` once they are gone.
+
 ### Scripted EPUBs run against the app origin
 
 **This is a regression from the foliate-js migration, not a pre-existing gap.**

backend/tests/conftest.py

@@ -2,6 +2,8 @@ from pathlib import Path
 from uuid import uuid4
 import pytest
 
+from chitai import services
+
 from advanced_alchemy.base import UUIDAuditBase
 from litestar.testing import AsyncTestClient
 from sqlalchemy import text
@@ -155,7 +157,6 @@ async def other_authenticated_client(
 
 
 # Service fixtures
-from chitai import services
 
 
 @pytest.fixture

backend/tests/integration/test_book.py

@@ -1,6 +1,7 @@
 import pytest
 from httpx import AsyncClient
 from pathlib import Path
+from litestar.status_codes import HTTP_400_BAD_REQUEST
 
 
 @pytest.mark.parametrize(
@@ -218,7 +219,9 @@ async def test_list_books_by_id(populated_authenticated_client: AsyncClient) ->
     compare a bigint primary key against them. Nothing called it until a screen needed
     to fetch a handful of books by id.
     """
-    response = await populated_authenticated_client.get("/books?ids=1&ids=2&pageSize=10")
+    response = await populated_authenticated_client.get(
+        "/books?ids=1&ids=2&pageSize=10"
+    )
 
     assert response.status_code == 200
     assert sorted(book["id"] for book in response.json()["items"]) == [1, 2]
@@ -228,7 +231,7 @@ async def test_get_book_by_id(populated_authenticated_client: AsyncClient) -> No
     """Test retrieving a specific book by ID."""
 
     # Retrieve the book
-    response = await populated_authenticated_client.get(f"/books/1")
+    response = await populated_authenticated_client.get("/books/1")
 
     assert response.status_code == 200
     book_data = response.json()
@@ -300,13 +303,13 @@ async def test_delete_book_metadata_only(
 
     # Delete book without deleting files
     response = await populated_authenticated_client.delete(
-        f"/books?book_ids=3&delete_files=false&library_id=1"
+        "/books?book_ids=3&delete_files=false&library_id=1"
     )
 
     assert response.status_code == 204
 
     # Verify book is deleted
-    get_response = await populated_authenticated_client.get(f"/books/3")
+    get_response = await populated_authenticated_client.get("/books/3")
     assert get_response.status_code == 404
 
 
@@ -317,7 +320,7 @@ async def test_delete_book_with_files(
 
     # Delete book and files
     response = await populated_authenticated_client.delete(
-        f"/books?book_ids=3&delete_files=true&library_id=1"
+        "/books?book_ids=3&delete_files=true&library_id=1"
     )
 
     assert response.status_code == 204
@@ -330,7 +333,7 @@ async def test_delete_specific_book_files(
 
     # Delete specific file
     response = await populated_authenticated_client.delete(
-        f"/books/1/files?file_ids=1",
+        "/books/1/files?file_ids=1",
     )
 
     assert response.status_code == 204
@@ -347,7 +350,7 @@ async def test_update_reading_progress(
     }
 
     response = await populated_authenticated_client.post(
-        f"/books/progress/1",
+        "/books/progress/1",
         json=progress_data,
     )
 
@@ -423,7 +426,9 @@ async def test_create_books_groups_formats_within_one_folder(
 ) -> None:
     """Picking a book's own folder yields one book with both formats, not two books."""
     epub = Path("tests/data_files/Metamorphosis - Franz Kafka.epub").read_bytes()
-    pdf = Path("tests/data_files/Calculus Made Easy - Silvanus Thompson.pdf").read_bytes()
+    pdf = Path(
+        "tests/data_files/Calculus Made Easy - Silvanus Thompson.pdf"
+    ).read_bytes()
 
     files = [
         ("files", ("Metamorphosis/Metamorphosis.epub", epub, "application/epub+zip")),
@@ -534,7 +539,9 @@ class TestDuplicateHandling:
                     "files",
                     (
                         "war.epub",
-                        Path("tests/data_files/The Art of War - Sun Tzu.epub").read_bytes(),
+                        Path(
+                            "tests/data_files/The Art of War - Sun Tzu.epub"
+                        ).read_bytes(),
                         "application/epub+zip",
                     ),
                 )
@@ -550,7 +557,9 @@ class TestDuplicateHandling:
                     "files",
                     (
                         "war.epub",
-                        Path("tests/data_files/The Art of War - Sun Tzu.epub").read_bytes(),
+                        Path(
+                            "tests/data_files/The Art of War - Sun Tzu.epub"
+                        ).read_bytes(),
                         "application/epub+zip",
                     ),
                 )
@@ -736,7 +745,9 @@ class TestDuplicateBooks:
         assert len(merged["files"]) == 2
 
         # The folded record is gone, and the group it formed with it.
-        assert (await authenticated_client.get(f"/books/{fold['id']}")).status_code == 404
+        assert (
+            await authenticated_client.get(f"/books/{fold['id']}")
+        ).status_code == 404
         groups = await authenticated_client.get("/books/duplicate-books?library_id=1")
         assert groups.json() == []
 
@@ -786,16 +797,6 @@ class TestDuplicateBooks:
 # async def test_edit_book_metadata(authenticated_client: AsyncClient) -> None:
 #     raise NotImplementedError()
 
-import pytest
-import aiofiles
-from httpx import AsyncClient
-from pathlib import Path
-from litestar.status_codes import HTTP_400_BAD_REQUEST
-
-import pytest
-from httpx import AsyncClient
-from datetime import date
-
 
 class TestMetadataUpdates:
     @pytest.mark.parametrize(
@@ -849,8 +850,10 @@ class TestMetadataUpdates:
             (
                 "authors",  # Update with new authors
                 ["New Author 1", "New Author 2"],
-                lambda data: {a["name"] for a in data["authors"]}
+                lambda data: (
-                == {"New Author 1", "New Author 2"},
+                    {a["name"] for a in data["authors"]}
+                    == {"New Author 1", "New Author 2"}
+                ),
             ),
             (
                 "authors",  # Clear authors
@@ -860,8 +863,9 @@ class TestMetadataUpdates:
             (
                 "tags",  # Update with new tags
                 ["Tag 1", "Tag 2", "Tag 3"],
-                lambda data: {t["name"] for t in data["tags"]}
+                lambda data: (
-                == {"Tag 1", "Tag 2", "Tag 3"},
+                    {t["name"] for t in data["tags"]} == {"Tag 1", "Tag 2", "Tag 3"}
+                ),
             ),
             (
                 "tags",  # Clear tags
@@ -881,8 +885,10 @@ class TestMetadataUpdates:
             (
                 "identifiers",  # Update with new identifiers
                 {"isbn-13": "978-1234567890", "doi": "10.example/id"},
-                lambda data: data["identifiers"]
+                lambda data: (
-                == {"isbn-13": "978-1234567890", "doi": "10.example/id"},
+                    data["identifiers"]
+                    == {"isbn-13": "978-1234567890", "doi": "10.example/id"}
+                ),
             ),
             (
                 "identifiers",  # Clear identifiers
@@ -1053,7 +1059,7 @@ class TestMetadataUpdates:
 
         result = response.json()
 
-        assert result[updated_field] == None
+        assert result[updated_field] is None
 
     @pytest.mark.parametrize(
         ("updated_field"),
@@ -1215,7 +1221,9 @@ class TestFileManagement:
             pytest.skip("Book has no files")
 
         file_id = book_data["files"][0]["id"]
-        filename = book_data["files"][0].get("path")
+        # TODO: this test asserts only the 204 and never checks the disk, so the flag it is
+        # named for is untested. See TODO.md; drop the noqa when the assertion lands.
+        filename = book_data["files"][0].get("path")  # noqa: F841
 
         # Remove file without deleting from filesystem
         response = await populated_authenticated_client.delete(
@@ -1240,7 +1248,8 @@ class TestFileManagement:
 
         book_data = add_response.json()
         file_id = book_data["files"][-1]["id"]
-        file_path = book_data["files"][-1].get("path")
+        # TODO: as above -- the file is never checked for removal from disk.
+        file_path = book_data["files"][-1].get("path")  # noqa: F841
 
         # Remove file with deletion from filesystem
         response = await populated_authenticated_client.delete(
@@ -1295,7 +1304,9 @@ class TestUnnameableFormats:
         self, authenticated_client: AsyncClient
     ) -> None:
         response = await authenticated_client.post(
-            "/books?library_id=1", files=self.upload("Dune.mobi"), data={"library_id": 1}
+            "/books?library_id=1",
+            files=self.upload("Dune.mobi"),
+            data={"library_id": 1},
         )
 
         assert response.status_code == 201
@@ -1323,9 +1334,7 @@ class TestUnnameableFormats:
         assert detail.status_code == 200
         assert detail.json()["files"][0]["content_type"] is None
 
-    async def test_the_file_downloads(
+    async def test_the_file_downloads(self, authenticated_client: AsyncClient) -> None:
-        self, authenticated_client: AsyncClient
-    ) -> None:
         """Litestar supplies its own media type when the row carries none."""
         created = await authenticated_client.post(
             "/books?library_id=1",

backend/tests/integration/test_bookshelf.py

@@ -1,4 +1,3 @@
-import pytest
 from httpx import AsyncClient
 
 
@@ -200,7 +199,6 @@ async def test_remove_books_from_shelf(
         "/books", params={"shelves": shelf_id}
     )
 
-    
     assert books_response.status_code == 200
     assert books_response.json()["total"] == 2
 

backend/tests/integration/test_calibre_import.py

@@ -42,7 +42,9 @@ def fx_source(tmp_path: Path) -> Path:
         cover=True,
         formats={"EPUB": EPUB},
     )
-    fixture.add_book(2, "The Art of War", authors=["Sun Tzu"], formats={"EPUB": OTHER_EPUB})
+    fixture.add_book(
+        2, "The Art of War", authors=["Sun Tzu"], formats={"EPUB": OTHER_EPUB}
+    )
     fixture.add_book(3, "Metadata Only", authors=["Nobody"])
 
     return fixture.commit()
@@ -95,7 +97,8 @@ async def test_an_uploaded_library_imports(
     authenticated_client: AsyncClient, source: Path, tmp_path: Path
 ) -> None:
     status, job = await upload(
-        authenticated_client, zip_of(source, tmp_path / "out", prefix="Calibre Library/")
+        authenticated_client,
+        zip_of(source, tmp_path / "out", prefix="Calibre Library/"),
     )
 
     assert status == 202
@@ -278,7 +281,9 @@ async def test_a_second_copy_is_counted_as_a_possible_duplicate(
     padded.write_bytes(EPUB.read_bytes() + b"\0" * 64)
 
     fixture = CalibreFixture(tmp_path / "calibre")
-    fixture.add_book(1, "The Metamorphosis", authors=["Franz Kafka"], formats={"EPUB": EPUB})
+    fixture.add_book(
+        1, "The Metamorphosis", authors=["Franz Kafka"], formats={"EPUB": EPUB}
+    )
     fixture.add_book(
         2, "The Metamorphosis", authors=["Franz Kafka"], formats={"EPUB": padded}
     )

backend/tests/integration/test_file_hash.py

@@ -8,7 +8,9 @@ from pathlib import Path
 # Known KOReader hashes for test files
 TEST_FILES = {
     "Moby Dick; Or, The Whale - Herman Melville.epub": {
-        "path": Path("tests/data_files/Moby Dick; Or, The Whale - Herman Melville.epub"),
+        "path": Path(
+            "tests/data_files/Moby Dick; Or, The Whale - Herman Melville.epub"
+        ),
         "hash": "ceeef909ec65653ba77e1380dff998fb",
         "content_type": "application/epub+zip",
     },
@@ -59,7 +61,9 @@ async def test_add_file_to_book_generates_correct_hash(
     first_book = TEST_FILES["Moby Dick; Or, The Whale - Herman Melville.epub"]
     first_content = first_book["path"].read_bytes()
 
-    files = [("files", (first_book["path"].name, first_content, first_book["content_type"]))]
+    files = [
+        ("files", (first_book["path"].name, first_content, first_book["content_type"]))
+    ]
     data = {"library_id": "1"}
 
     create_response = await authenticated_client.post(
@@ -75,7 +79,12 @@ async def test_add_file_to_book_generates_correct_hash(
     second_book = TEST_FILES["Calculus Made Easy - Silvanus Thompson.pdf"]
     second_content = second_book["path"].read_bytes()
 
-    add_files = [("data", (second_book["path"].name, second_content, second_book["content_type"]))]
+    add_files = [
+        (
+            "data",
+            (second_book["path"].name, second_content, second_book["content_type"]),
+        )
+    ]
 
     add_response = await authenticated_client.post(
         f"/books/{book_id}/files",

backend/tests/integration/test_library.py

@@ -40,5 +40,5 @@ async def test_create_library(
         assert result["name"] == "Test Library"
         assert result["root_path"] == f"{tmp_path}/books"
         assert result["path_template"] == "{author}/{title}"
-        assert result["read_only"] == False
+        assert result["read_only"] is False
         assert result["description"] is None

backend/tests/unit/test_filesystem_library.py

@@ -2,7 +2,10 @@
 
 from pathlib import Path
 
-from chitai.services.filesystem_library import BookPathGenerator, sanitize_path_component
+from chitai.services.filesystem_library import (
+    BookPathGenerator,
+    sanitize_path_component,
+)
 
 
 ROOT = Path("/library")
@@ -23,12 +26,15 @@ def test_a_book_with_no_authors() -> None:
 
 
 def test_a_series_adds_a_level_and_pads_the_position() -> None:
-    assert path_for(
+    assert (
+        path_for(
             title="Persepolis Rising",
             authors=["James S. A. Corey"],
             series="The Expanse",
             series_position="7",
-    ) == ROOT / "James S. A. Corey" / "The Expanse" / "07 - Persepolis Rising"
+        )
+        == ROOT / "James S. A. Corey" / "The Expanse" / "07 - Persepolis Rising"
+    )
 
 
 def test_a_slash_in_a_title_does_not_add_a_directory() -> None:
@@ -43,16 +49,25 @@ def test_a_slash_in_a_title_does_not_add_a_directory() -> None:
     generated = path_for(title="Back in Black: AC/DC", authors=["Murray Engleheart"])
 
     assert generated == ROOT / "Murray Engleheart" / "Back in Black: AC_DC"
-    assert generated.relative_to(ROOT).parts == ("Murray Engleheart", "Back in Black: AC_DC")
+    assert generated.relative_to(ROOT).parts == (
+        "Murray Engleheart",
+        "Back in Black: AC_DC",
+    )
 
 
 def test_a_slash_in_an_author_or_series_is_handled_too() -> None:
     assert path_for(title="Split", authors=["A/B Collective"]) == (
         ROOT / "A_B Collective" / "Split"
     )
-    assert path_for(
+    assert (
-        title="Volume One", authors=["Someone"], series="Either/Or", series_position="1"
+        path_for(
-    ) == ROOT / "Someone" / "Either_Or" / "01 - Volume One"
+            title="Volume One",
+            authors=["Someone"],
+            series="Either/Or",
+            series_position="1",
+        )
+        == ROOT / "Someone" / "Either_Or" / "01 - Volume One"
+    )
 
 
 def test_control_characters_are_removed() -> None:

backend/tests/unit/test_matching.py

@@ -54,7 +54,8 @@ class TestNormalizeTitle:
         assert normalize_title("The") == "the"
 
     @pytest.mark.parametrize(
-        "title", ["Catch 22", "Fahrenheit 451", "Blade Runner 2049", "1984", "Apollo 13"]
+        "title",
+        ["Catch 22", "Fahrenheit 451", "Blade Runner 2049", "1984", "Apollo 13"],
     )
     def test_a_number_is_not_an_edition(self, title: str) -> None:
         """Edition stripping keys on the `e`; a bare number is part of the title."""
@@ -163,8 +164,13 @@ class TestNormalizeIdentifier:
 
     def test_uuids_are_refused(self) -> None:
         """Generated per build, so they only re-find what the hash check catches."""
-        assert normalize_identifier("uuid", "3f2b1c4e-1111-2222-3333-444455556666") is None
+        assert (
-        assert normalize_identifier("urn:uuid", "3f2b1c4e-1111-2222-3333-444455556666") is None
+            normalize_identifier("uuid", "3f2b1c4e-1111-2222-3333-444455556666") is None
+        )
+        assert (
+            normalize_identifier("urn:uuid", "3f2b1c4e-1111-2222-3333-444455556666")
+            is None
+        )
 
     def test_other_schemes_keep_their_own_key(self) -> None:
         assert normalize_identifier("asin", "B000FC0PDA") == "asin:b000fc0pda"
@@ -187,7 +193,9 @@ class TestIsbnConversion:
         assert isbn10_to_isbn13("043942089X") == "9780439420891"
 
     @pytest.mark.parametrize("isbn", ["0486282113", "9780486282114", "nonsense"])
-    def test_anything_that_is_not_an_isbn_10_converts_to_nothing(self, isbn: str) -> None:
+    def test_anything_that_is_not_an_isbn_10_converts_to_nothing(
+        self, isbn: str
+    ) -> None:
         assert isbn10_to_isbn13(isbn) is None
 
 

backend/tests/unit/test_metadata_extractor.py

@@ -22,7 +22,6 @@ class TestEpubExtractor:
         assert metadata["published_date"] == date(year=2001, month=7, day=1)
 
 
-
 EPUB = Path("tests/data_files/Metamorphosis - Franz Kafka.epub")
 PDF = Path("tests/data_files/Calculus Made Easy - Silvanus Thompson.pdf")
 
@@ -31,7 +30,9 @@ PDF = Path("tests/data_files/Calculus Made Easy - Silvanus Thompson.pdf")
 class TestIdentifierMerging:
     """A book's formats each contribute identifiers; none of them replaces the rest."""
 
-    async def test_every_format_contributes(self, monkeypatch: pytest.MonkeyPatch) -> None:
+    async def test_every_format_contributes(
+        self, monkeypatch: pytest.MonkeyPatch
+    ) -> None:
         """
         Identifiers are a collection, not a single value.
 
@@ -47,7 +48,9 @@ class TestIdentifierMerging:
             }
 
         async def pdf(_file):
-            return {"identifiers": {"isbn-13": "9781718500402", "isbn-10": "1593270356"}}
+            return {
+                "identifiers": {"isbn-13": "9781718500402", "isbn-10": "1593270356"}
+            }
 
         monkeypatch.setattr(EpubExtractor, "extract_metadata", epub)
         monkeypatch.setattr(PdfExtractor, "extract_metadata", pdf)
@@ -133,7 +136,9 @@ class TestSplitEdition:
             ),
         ],
     )
-    def test_editions_are_split_out(self, title: str, stripped: str, edition: int) -> None:
+    def test_editions_are_split_out(
+        self, title: str, stripped: str, edition: int
+    ) -> None:
         assert split_edition(title) == (stripped, edition)
 
     @pytest.mark.parametrize(
@@ -171,7 +176,10 @@ class TestEditionFromFiles:
         """The PDF fixture calls itself a 2nd edition in its own metadata title."""
         metadata = await Extractor.extract_metadata([PDF])
 
-        assert metadata["title"] == "The Project Gutenberg eBook #33283: Calculus Made Easy"
+        assert (
+            metadata["title"]
+            == "The Project Gutenberg eBook #33283: Calculus Made Easy"
+        )
         assert metadata["edition"] == 2
 
 

backend/tests/unit/test_services/test_book_service.py

@@ -25,7 +25,9 @@ PDF = DATA_FILES / "Calculus Made Easy - Silvanus Thompson.pdf"
 def upload(path: Path, name: str | None = None) -> UploadFile:
     """An uploaded file carrying the bytes of one of the test fixtures."""
     return UploadFile(
-        content_type="application/pdf" if path.suffix == ".pdf" else "application/epub+zip",
+        content_type="application/pdf"
+        if path.suffix == ".pdf"
+        else "application/epub+zip",
         filename=name or path.name,
         file_data=path.read_bytes(),
     )
@@ -538,9 +540,7 @@ class TestBookPathCollisions:
 
         assert original.path != forced.path
 
-        paths = {
+        paths = {Path(book.path) / book.files[0].path for book in (original, forced)}
-            Path(book.path) / book.files[0].path for book in (original, forced)
-        }
         assert len(paths) == 2
         assert all(path.is_file() for path in paths)
 
@@ -581,7 +581,10 @@ class TestBookPathCollisions:
         # Renamed onto the first book's author and title.
         await books_service.update_book(
             second.books[0].id,
-            {"title": original.title, "authors": [author.name for author in original.authors]},
+            {
+                "title": original.title,
+                "authors": [author.name for author in original.authors],
+            },
             test_library,
         )
 
@@ -743,7 +746,8 @@ class TestDuplicateBooks:
         )
 
         matches = await books_service.find_duplicate_books(
-            {"title": "Building Microservices", "authors": ["Newman, Sam;"]}, test_library
+            {"title": "Building Microservices", "authors": ["Newman, Sam;"]},
+            test_library,
         )
 
         assert [match.book_id for match in matches] == [stored.id]
@@ -834,16 +838,22 @@ class TestDuplicateBooks:
             "series": "Foundation",
         }
 
-        assert await books_service.find_duplicate_books(
+        assert (
+            await books_service.find_duplicate_books(
                 incoming | {"series_position": "2"}, test_library
-        ) == []
+            )
+            == []
+        )
 
         # The same volume, written a little differently, still matches.
-        assert len(
+        assert (
+            len(
                 await books_service.find_duplicate_books(
                     incoming | {"series_position": "1.0"}, test_library
                 )
-        ) == 1
+            )
+            == 1
+        )
 
     async def test_a_book_is_not_its_own_duplicate(
         self, books_service: BookService, test_library: m.Library
@@ -909,7 +919,10 @@ class TestAuthorNames:
         existing row and then collides with it on the unique index.
         """
         first = await store_book(
-            books_service, test_library, title="Building Microservices", authors=["Sam Newman"]
+            books_service,
+            test_library,
+            title="Building Microservices",
+            authors=["Sam Newman"],
         )
         second = await store_book(
             books_service,
@@ -953,7 +966,9 @@ class TestAuthorNames:
         "Franz Kafka.epub" is not a person.
         """
         result = await books_service.create_many_from_files(
-            BooksCreateFromFiles(files=[upload(EPUB, "Some Unknown Book - Ada Lovelace.epub")]),
+            BooksCreateFromFiles(
+                files=[upload(EPUB, "Some Unknown Book - Ada Lovelace.epub")]
+            ),
             test_library,
         )
 
@@ -1014,7 +1029,10 @@ class TestMergeBooks:
     ) -> None:
         """The survivor keeps its own fields unless the caller says otherwise."""
         keep = await store_book(
-            books_service, test_library, title="Building Microservices", authors=["Sam Newman"]
+            books_service,
+            test_library,
+            title="Building Microservices",
+            authors=["Sam Newman"],
         )
         fold = await store_book(
             books_service,
@@ -1030,7 +1048,11 @@ class TestMergeBooks:
         assert merged.publisher is None
 
         other = await store_book(
-            books_service, test_library, title="Monolith", authors=["Sam Newman"], edition=3
+            books_service,
+            test_library,
+            title="Monolith",
+            authors=["Sam Newman"],
+            edition=3,
         )
         merged = await books_service.merge_books(
             keep.id, [other.id], test_library, metadata={"edition": 3}
@@ -1096,10 +1118,14 @@ class TestMergeBooks:
         await books_service.merge_books(keep.id, [fold.id], test_library)
 
         rows = (
+            (
                 await books_service.repository.session.execute(
                     select(m.BookProgress).where(m.BookProgress.book_id == keep.id)
                 )
-        ).scalars().all()
+            )
+            .scalars()
+            .all()
+        )
 
         assert [row.percentage for row in rows] == [0.6]
 
@@ -1112,13 +1138,23 @@ class TestMergeBooks:
     ) -> None:
         """Both books on one shelf must not leave the survivor linked to it twice."""
         keep = await store_book(
-            books_service, test_library, title="A", authors=["X"], tags=["Shared", "Only Keep"]
+            books_service,
+            test_library,
+            title="A",
+            authors=["X"],
+            tags=["Shared", "Only Keep"],
         )
         fold = await store_book(
-            books_service, test_library, title="B", authors=["X"], tags=["Shared", "Only Fold"]
+            books_service,
+            test_library,
+            title="B",
+            authors=["X"],
+            tags=["Shared", "Only Fold"],
         )
 
-        shelf = m.BookList(title="Later", user_id=test_user.id, library_id=test_library.id)
+        shelf = m.BookList(
+            title="Later", user_id=test_user.id, library_id=test_library.id
+        )
         session.add(shelf)
         await session.commit()
         session.add_all(
@@ -1131,13 +1167,21 @@ class TestMergeBooks:
 
         merged = await books_service.merge_books(keep.id, [fold.id], test_library)
 
-        assert sorted(tag.name for tag in merged.tags) == ["Only Fold", "Only Keep", "Shared"]
+        assert sorted(tag.name for tag in merged.tags) == [
+            "Only Fold",
+            "Only Keep",
+            "Shared",
+        ]
 
         links = (
+            (
                 await books_service.repository.session.execute(
                     select(m.BookListLink).where(m.BookListLink.book_id == keep.id)
                 )
-        ).scalars().all()
+            )
+            .scalars()
+            .all()
+        )
         assert len(links) == 1
 
     async def test_an_identifier_moves_only_under_a_name_the_survivor_lacks(

backend/tests/unit/test_services/test_bookshelf_service.py

@@ -2,19 +2,12 @@
 
 import pytest
 
+from sqlalchemy import select
 from sqlalchemy.ext.asyncio import AsyncSession
 
 from chitai.services import ShelfService
 from chitai.database import models as m
-
-
-import pytest
-from sqlalchemy import select
-
-from chitai.services.bookshelf import ShelfService
-from chitai.services import BookService
 from chitai.database.models.book_list import BookList, BookListLink
-from chitai.database import models as m
 
 
 @pytest.fixture

backend/tests/unit/test_services/test_calibre_import_service.py

@@ -201,7 +201,9 @@ async def test_importing_twice_creates_nothing(
     ]
 
     held_by = [
-        skipped.book_id for skipped in result.skipped if skipped.reason == "already stored"
+        skipped.book_id
+        for skipped in result.skipped
+        if skipped.reason == "already stored"
     ]
     assert all(book_id is not None for book_id in held_by)
 
@@ -223,7 +225,9 @@ async def test_a_file_the_catalogue_lists_but_disk_does_not(
         await source.close()
 
     assert len(result.created) == 1
-    assert [(s.calibre_id, s.reason) for s in result.skipped] == [(2, "no files on disk")]
+    assert [(s.calibre_id, s.reason) for s in result.skipped] == [
+        (2, "no files on disk")
+    ]
 
 
 async def test_one_broken_book_does_not_stop_the_import(
@@ -312,7 +316,11 @@ async def test_shared_authors_and_tags_are_one_row_each(
         1, "One", authors=["Franz Kafka"], tags=["Fiction"], formats={"EPUB": EPUB}
     )
     fixture.add_book(
-        2, "Two", authors=["Franz Kafka"], tags=["Fiction"], formats={"EPUB": OTHER_EPUB}
+        2,
+        "Two",
+        authors=["Franz Kafka"],
+        tags=["Fiction"],
+        formats={"EPUB": OTHER_EPUB},
     )
     root = fixture.commit()
 

backend/tests/unit/test_services/test_library_service.py

@@ -34,8 +34,8 @@ class TestLibraryServiceCRUD:
         assert library.name == "Test Library"
         assert library.root_path == library_path
         assert library.path_template == "{author}/{title}"
-        assert library.description == None
+        assert library.description is None
-        assert library.read_only == False
+        assert library.read_only is False
 
         # Check if directory was created
         assert Path(library.root_path).is_dir()
@@ -56,8 +56,8 @@ class TestLibraryServiceCRUD:
             read_only=False,
         )
 
-        with pytest.raises(PermissionError) as exc_info:
+        with pytest.raises(PermissionError):
-            library = await library_service.create(library_data)
+            await library_service.create(library_data)
 
         # Check if directory was created
         assert not Path(library_path).exists()
@@ -86,8 +86,8 @@ class TestLibraryServiceCRUD:
         assert library.name == "Test Library"
         assert library.root_path == library_path
         assert library.path_template == "{author}/{title}"
-        assert library.description == None
+        assert library.description is None
-        assert library.read_only == True
+        assert library.read_only is True
 
     async def test_create_library_read_only_nonexistent_path(
         self, library_service: LibraryService, tmp_path: Path
@@ -138,7 +138,7 @@ class TestLibraryServiceCRUD:
         assert library.root_path == "./books"
         assert library.path_template == "{author}/{title}"
         assert library.description is None
-        assert library.read_only == False
+        assert library.read_only is False
 
     # async def test_delete_library_keep_files(
     #     self, session: AsyncSession, library_service: LibraryService

backend/tests/unit/test_services/test_user_service.py

@@ -21,7 +21,7 @@ class TestUserServiceAuthentication:
 
         # Create a user with a known password
         password = "password123"
-        user = m.User(email=f"test@example.com", password=password)
+        user = m.User(email="test@example.com", password=password)
 
         session.add(user)
         await session.commit()
@@ -52,7 +52,7 @@ class TestUserServiceAuthentication:
 
         # Create user
         password = "password123"
-        user = m.User(email=f"test@example.com", password=password)
+        user = m.User(email="test@example.com", password=password)
 
         session.add(user)
         await session.commit()
@@ -85,7 +85,7 @@ class TestUserServiceCRUD:
     ) -> None:
         """Test getting user by email."""
 
-        user = m.User(email=f"test@example.com", password="password123")
+        user = m.User(email="test@example.com", password="password123")
 
         session.add(user)
         await session.commit()
@@ -102,12 +102,12 @@ class TestUserServiceCRUD:
         """Test creating a new user with a duplicate email."""
 
         # Create first user
-        user = m.User(email=f"test@example.com", password="password123")
+        user = m.User(email="test@example.com", password="password123")
         session.add(user)
         await session.commit()
 
         # Create second user
-        user = m.User(email=f"test@example.com", password="password12345")
+        user = m.User(email="test@example.com", password="password12345")
 
         with pytest.raises(IntegrityError) as exc_info:
             session.add(user)

frontend/AGENTS.md

@@ -157,18 +157,22 @@ but take a baseline first, because neither is clean (see below).
 
 Observed in the current tree — don't mistake these for intentional patterns to copy:
 
-- `pnpm check` is not clean. **Baseline as of 2026-08-13: 30 errors, 1 warning, 8 files**, most of
+- **`pnpm check` is clean as of 2026-08-17 and CI blocks on it** — 0 errors, 0 warnings. Any error
-  them in `src/routes/api/[...path]/+server.ts` (see below). Get your own baseline before assuming
+  you see is yours. `src/lib/schema/openapi/schema.d.ts` is
-  an error is yours. `src/lib/schema/openapi/schema.d.ts` was regenerated on that date and is
+  current; regenerate it after any backend API change, with
-  current; regenerate it again after any backend API change, with
   `pnpm exec openapi-typescript http://localhost:8000/schema/openapi.json -o src/lib/schema/openapi/schema.d.ts`
   against a backend running **your** branch — a stale server silently writes a stale file.
 - **Prettier is clean and CI blocks on it** — run `pnpm format` before finishing. Two things it
   must not touch are in `.prettierignore`: the vendored foliate-js, and
   `src/lib/schema/openapi/schema.d.ts`, which `openapi-typescript` regenerates in its own style.
-- `pnpm exec eslint .` reports **87 pre-existing errors as of 2026-08-17**, all in `src/`. CI runs
+- `pnpm exec eslint .` reports **2 errors as of 2026-08-17**, both `svelte/no-at-html-tags` in
-  it non-blocking (`continue-on-error`) until that reaches zero. `static/pdfjs/` is ignored
+  `collapsible-text.svelte`. They are a genuine XSS hole, not a lint nit — see `TODO.md`. CI runs
+  eslint non-blocking (`continue-on-error`) only until that is fixed. `static/pdfjs/` is ignored
   alongside `src/lib/vendor/` — it is vendored too, and linting it produced 1717 further errors.
+- Two rules are off for `**/*.svelte` in `eslint.config.js` because they predate runes and
+  misread them: `no-useless-assignment` (every `$bindable()` default) and
+  `@typescript-eslint/no-unused-expressions` (a bare `book;` declaring an `$effect` dependency).
+  A leading underscore marks an intentionally unused binding.
 - `src/routes/api/[...path]/+server.ts` — all four handlers are annotated `RequestHandler` while the
   import of that type is commented out at line 4. It also buffers whole **responses** with
   `arrayBuffer()` and forwards no `Range` header, so book downloads are not streamed. **Requests**

frontend/eslint.config.js

@@ -28,7 +28,18 @@ export default defineConfig(
 		rules: {
 			// typescript-eslint strongly recommend that you do not use the no-undef lint rule on TypeScript projects.
 			// see: https://typescript-eslint.io/troubleshooting/faqs/eslint/#i-get-errors-from-the-no-undef-rule-about-global-variables-not-being-defined-even-though-there-are-no-typescript-errors
-			'no-undef': 'off'
+			'no-undef': 'off',
+			// A leading underscore marks a binding that exists to hold a position — a callback
+			// parameter the signature requires, or the discarded half of a destructure.
+			'@typescript-eslint/no-unused-vars': [
+				'error',
+				{
+					argsIgnorePattern: '^_',
+					varsIgnorePattern: '^_',
+					caughtErrorsIgnorePattern: '^_',
+					destructuredArrayIgnorePattern: '^_'
+				}
+			]
 		}
 	},
 	{
@@ -41,8 +52,15 @@ export default defineConfig(
 		// no-useless-assignment joined eslint:recommended in ESLint 10, and its flow analysis
 		// does not model runes: it reads `let { ref = $bindable(null) } = $props()` as a value
 		// that is never read. Deleting the default, as it suggests, breaks the binding.
+		//
+		// no-unused-expressions is off for the same reason: a bare `book;` inside an $effect is
+		// how a reactive dependency is declared when the read would otherwise be untracked.
+		// Removing the statement stops the effect re-running.
 		files: ['**/*.svelte'],
-		rules: { 'no-useless-assignment': 'off' }
+		rules: {
+			'no-useless-assignment': 'off',
+			'@typescript-eslint/no-unused-expressions': 'off'
+		}
 	},
 	{
 		files: ['**/*.svelte', '**/*.svelte.ts', '**/*.svelte.js'],

frontend/package.json

@@ -19,10 +19,10 @@
 		"@eslint/js": "^10.0.1",
 		"@iconify/svelte": "^5.2.2",
 		"@internationalized/date": "^3.12.3",
-		"@lucide/svelte": "^0.544.0",
+		"@lucide/svelte": "^1.31.0",
 		"@sveltejs/adapter-node": "^5.5.7",
 		"@sveltejs/kit": "^2.70.2",
-		"@sveltejs/vite-plugin-svelte": "^6.2.4",
+		"@sveltejs/vite-plugin-svelte": "^7.3.0",
 		"@tailwindcss/vite": "^4.3.3",
 		"@types/node": "^26.2.0",
 		"bits-ui": "^2.18.1",
@@ -31,10 +31,10 @@
 		"eslint-config-prettier": "^10.1.8",
 		"eslint-plugin-svelte": "^3.23.0",
 		"globals": "^17.11.0",
-		"jsrepo": "^2.5.2",
+		"jsrepo": "^3.8.1",
 		"openapi-typescript": "^7.13.0",
 		"prettier": "^3.9.6",
-		"prettier-plugin-svelte": "^3.5.2",
+		"prettier-plugin-svelte": "^4.1.1",
 		"prettier-plugin-tailwindcss": "^0.8.1",
 		"svelte": "^5.56.9",
 		"svelte-check": "^4.7.6",
@@ -43,9 +43,9 @@
 		"tailwind-variants": "^3.3.1",
 		"tailwindcss": "^4.3.3",
 		"tw-animate-css": "^1.4.0",
-		"typescript": "^5.9.3",
+		"typescript": "^6.0.3",
 		"typescript-eslint": "^8.67.0",
-		"vite": "^7.3.6"
+		"vite": "^8.2.1"
 	},
 	"dependencies": {
 		"construct-style-sheets-polyfill": "^3.1.0",

frontend/src/lib/api/auth.remote.ts

@@ -4,7 +4,7 @@ import { BACKEND_API_URL } from '$lib/server/config';
 import { invalid, redirect } from '@sveltejs/kit';
 
 export const login = form(loginSchema, async (data, issue) => {
-	const { cookies, locals } = getRequestEvent();
+	const { cookies } = getRequestEvent();
 
 	// Create URL-encoded form data
 	const formData = new URLSearchParams();

frontend/src/lib/api/library.remote.ts

@@ -25,6 +25,6 @@ export const createLibrary = form(libraryCreateSchema, async (data) => {
 	return await response.json();
 });
 
-export const deleteLibrary = query('unchecked', async (data) => {
+export const deleteLibrary = query('unchecked', async (_data) => {
 	throw new Error('Not implemented');
 });

frontend/src/lib/components/forms/book-delete.svelte

@@ -3,8 +3,6 @@
 	import { Checkbox } from '$lib/components/ui/checkbox/index.js';
 	import { Button } from '$lib/components/ui/button/index.js';
 	import * as Dialog from '$lib/components/ui/dialog/index.js';
-	import { getBookSelectionState } from '$lib/state/bookSelection.svelte';
-	import { getBookOperationsState } from '$lib/state/bookOperations.svelte';
 
 	let {
 		open = $bindable(),
@@ -13,12 +11,9 @@
 	}: {
 		open: boolean;
 		title?: string;
-		deleteFn: (deleteFiles: boolean) => {};
+		deleteFn: (deleteFiles: boolean) => void | Promise<void>;
 	} = $props();
 
-	const selectedState = getBookSelectionState();
-	const bookOps = getBookOperationsState();
-
 	let deleteFiles = $state(false);
 </script>
 

frontend/src/lib/components/forms/device-create-form.svelte

@@ -39,7 +39,7 @@
 			<Field.Field>
 				<Field.Label for="name">Device name</Field.Label>
 				<Input {...createDevice.fields.name.as('text')} placeholder="e.g. Kindle Paperwhite" />
-				{#each createDevice.fields.name.issues() ?? [] as issue}
+				{#each createDevice.fields.name.issues() ?? [] as issue, i (i)}
 					<Field.Error>{issue.message}</Field.Error>
 				{/each}
 			</Field.Field>

frontend/src/lib/components/forms/edit-book/edit-metadata.svelte

@@ -128,7 +128,7 @@
 	<Field.Field class="col-span-full">
 		<Field.Label for="title">Title</Field.Label>
 		<Input {...updateBookMetadata.fields.title.as('text')} />
-		{#each updateBookMetadata.fields.title.issues() ?? [] as issue}
+		{#each updateBookMetadata.fields.title.issues() ?? [] as issue, i (i)}
 			<Field.Error>{issue.message}</Field.Error>
 		{/each}
 	</Field.Field>
@@ -136,7 +136,7 @@
 	<Field.Field>
 		<Field.Label for="subtitle">Subtitle</Field.Label>
 		<Input {...updateBookMetadata.fields.subtitle.as('text')} />
-		{#each updateBookMetadata.fields.subtitle.issues() ?? [] as issue}
+		{#each updateBookMetadata.fields.subtitle.issues() ?? [] as issue, i (i)}
 			<Field.Error>{issue.message}</Field.Error>
 		{/each}
 	</Field.Field>
@@ -144,7 +144,7 @@
 	<Field.Field>
 		<Field.Label for="edition">Edition</Field.Label>
 		<Input {...updateBookMetadata.fields.edition.as('number')} />
-		{#each updateBookMetadata.fields.edition.issues() ?? [] as issue}
+		{#each updateBookMetadata.fields.edition.issues() ?? [] as issue, i (i)}
 			<Field.Error>{issue.message}</Field.Error>
 		{/each}
 	</Field.Field>
@@ -152,7 +152,7 @@
 	<Field.Field>
 		<Field.Label for="series">Series</Field.Label>
 		<Input {...updateBookMetadata.fields.series.as('text')} />
-		{#each updateBookMetadata.fields.series.issues() ?? [] as issue}
+		{#each updateBookMetadata.fields.series.issues() ?? [] as issue, i (i)}
 			<Field.Error>{issue.message}</Field.Error>
 		{/each}
 	</Field.Field>
@@ -161,7 +161,7 @@
 		<Field.Field>
 			<Field.Label for="series_position">No.</Field.Label>
 			<Input {...updateBookMetadata.fields.series_position.as('text')} />
-			{#each updateBookMetadata.fields.series_position.issues() ?? [] as issue}
+			{#each updateBookMetadata.fields.series_position.issues() ?? [] as issue, i (i)}
 				<Field.Error>{issue.message}</Field.Error>
 			{/each}
 		</Field.Field>
@@ -169,7 +169,7 @@
 		<Field.Field>
 			<Field.Label for="language">Language</Field.Label>
 			<Input {...updateBookMetadata.fields.language.as('text')} />
-			{#each updateBookMetadata.fields.language.issues() ?? [] as issue}
+			{#each updateBookMetadata.fields.language.issues() ?? [] as issue, i (i)}
 				<Field.Error>{issue.message}</Field.Error>
 			{/each}
 		</Field.Field>
@@ -185,10 +185,10 @@
 			placeholder="Add an author"
 			class="min-h-10 p-2 text-sm"
 		/>
-		{#each authors as author}
+		{#each authors as author, i (i)}
 			<input class="hidden" {...updateBookMetadata.fields.authors.as('checkbox', author)} />
 		{/each}
-		{#each updateBookMetadata.fields.authors.issues() ?? [] as issue}
+		{#each updateBookMetadata.fields.authors.issues() ?? [] as issue, i (i)}
 			<Field.Error>{issue.message}</Field.Error>
 		{/each}
 	</Field.Field>
@@ -201,10 +201,10 @@
 			placeholder="Add a tag"
 			class="min-h-10 p-2 text-sm"
 		/>
-		{#each tags as tag}
+		{#each tags as tag, i (i)}
 			<input class="hidden" {...updateBookMetadata.fields.tags.as('checkbox', tag)} />
 		{/each}
-		{#each updateBookMetadata.fields.tags.issues() ?? [] as issue}
+		{#each updateBookMetadata.fields.tags.issues() ?? [] as issue, i (i)}
 			<Field.Error>{issue.message}</Field.Error>
 		{/each}
 	</Field.Field>
@@ -214,7 +214,7 @@
 	<Field.Field>
 		<Field.Label for="publisher">Publisher</Field.Label>
 		<Input {...updateBookMetadata.fields.publisher.as('text')} />
-		{#each updateBookMetadata.fields.publisher.issues() ?? [] as issue}
+		{#each updateBookMetadata.fields.publisher.issues() ?? [] as issue, i (i)}
 			<Field.Error>{issue.message}</Field.Error>
 		{/each}
 	</Field.Field>
@@ -223,7 +223,7 @@
 		<Field.Field>
 			<Field.Label for="published_date">Published</Field.Label>
 			<Input {...updateBookMetadata.fields.published_date.as('date')} />
-			{#each updateBookMetadata.fields.published_date.issues() ?? [] as issue}
+			{#each updateBookMetadata.fields.published_date.issues() ?? [] as issue, i (i)}
 				<Field.Error>{issue.message}</Field.Error>
 			{/each}
 		</Field.Field>
@@ -231,7 +231,7 @@
 		<Field.Field>
 			<Field.Label for="pages">Pages</Field.Label>
 			<Input {...updateBookMetadata.fields.pages.as('number')} />
-			{#each updateBookMetadata.fields.pages.issues() ?? [] as issue}
+			{#each updateBookMetadata.fields.pages.issues() ?? [] as issue, i (i)}
 				<Field.Error>{issue.message}</Field.Error>
 			{/each}
 		</Field.Field>
@@ -240,7 +240,7 @@
 	<Field.Field class="col-span-full">
 		<Field.Label for="identifiers">Identifiers</Field.Label>
 		<div class="flex flex-col gap-2">
-			{#each identifierKeys as _, idx}
+			{#each identifierKeys as _, idx (idx)}
 				<div class="grid grid-cols-[1fr_1.6fr_auto] gap-2">
 					<Input bind:value={identifierKeys[idx]} placeholder="ISBN, DOI…" />
 					<Input bind:value={identifierValues[idx]} placeholder="Value" />
@@ -271,7 +271,7 @@
 	<Field.Field class="col-span-full">
 		<Field.Label for="description" class="sr-only">Description</Field.Label>
 		<Textarea {...updateBookMetadata.fields.description.as('text')} rows={6} />
-		{#each updateBookMetadata.fields.description.issues() ?? [] as issue}
+		{#each updateBookMetadata.fields.description.issues() ?? [] as issue, i (i)}
 			<Field.Error>{issue.message}</Field.Error>
 		{/each}
 	</Field.Field>

frontend/src/lib/components/forms/library-create-form.svelte

@@ -56,7 +56,7 @@
 							<Field.Field>
 								<Field.Label for="name">Library name</Field.Label>
 								<Input {...createLibrary.fields.name.as('text')} />
-								{#each createLibrary.fields.name.issues() ?? [] as issue}
+								{#each createLibrary.fields.name.issues() ?? [] as issue, i (i)}
 									<Field.Error>{issue.message}</Field.Error>
 								{/each}
 							</Field.Field>
@@ -73,7 +73,7 @@
 					<Field.Field>
 						<Field.Label for="description">Description</Field.Label>
 						<Textarea {...createLibrary.fields.description.as('text')} />
-						{#each createLibrary.fields.description.issues() ?? [] as issue}
+						{#each createLibrary.fields.description.issues() ?? [] as issue, i (i)}
 							<Field.Error>{issue.message}</Field.Error>
 						{/each}
 					</Field.Field>
@@ -82,7 +82,7 @@
 					<Field.Field>
 						<Field.Label for="root_path">Root Path</Field.Label>
 						<Input {...createLibrary.fields.root_path.as('text')} />
-						{#each createLibrary.fields.root_path.issues() ?? [] as issue}
+						{#each createLibrary.fields.root_path.issues() ?? [] as issue, i (i)}
 							<Field.Error>{issue.message}</Field.Error>
 						{/each}
 						<Field.Description class="text-xs">
@@ -94,7 +94,7 @@
 					<Field.Field>
 						<Field.Label for="path_template">Path Template</Field.Label>
 						<Input {...createLibrary.fields.path_template.as('text')} />
-						{#each createLibrary.fields.path_template.issues() ?? [] as issue}
+						{#each createLibrary.fields.path_template.issues() ?? [] as issue, i (i)}
 							<Field.Error>{issue.message}</Field.Error>
 						{/each}
 						<Field.Description class="text-xs">

frontend/src/lib/components/forms/login-form.svelte

@@ -21,7 +21,7 @@
 					<Field.Field>
 						<Field.Label for="email">Email</Field.Label>
 						<Input {...login.fields.email.as('email')} />
-						{#each login.fields.email.issues() ?? [] as issue}
+						{#each login.fields.email.issues() ?? [] as issue, i (i)}
 							<Field.Error>{issue.message}</Field.Error>
 						{/each}
 					</Field.Field>
@@ -30,7 +30,7 @@
 					<Field.Field>
 						<Field.Label for="password">Password</Field.Label>
 						<Input {...login.fields.password.as('password')} />
-						{#each login.fields.password.issues() ?? [] as issue}
+						{#each login.fields.password.issues() ?? [] as issue, i (i)}
 							<Field.Error>{issue.message}</Field.Error>
 						{/each}
 					</Field.Field>

frontend/src/lib/components/forms/signup-form.svelte

@@ -47,7 +47,7 @@
 					<Field.Field>
 						<Field.Label for="email">Email</Field.Label>
 						<Input {...signup.fields.email.as('email')} />
-						{#each signup.fields.email.issues() ?? [] as issue}
+						{#each signup.fields.email.issues() ?? [] as issue, i (i)}
 							<Field.Error>{issue.message}</Field.Error>
 						{/each}
 					</Field.Field>
@@ -56,7 +56,7 @@
 					<Field.Field>
 						<Field.Label for="password">Password</Field.Label>
 						<Input {...signup.fields.password.as('password')} />
-						{#each signup.fields.password.issues() ?? [] as issue}
+						{#each signup.fields.password.issues() ?? [] as issue, i (i)}
 							<Field.Error>{issue.message}</Field.Error>
 						{/each}
 					</Field.Field>
@@ -65,7 +65,7 @@
 					<Field.Field>
 						<Field.Label for="confirmPassword">Confirm Password</Field.Label>
 						<Input {...signup.fields.confirmPassword.as('password')} />
-						{#each signup.fields.confirmPassword.issues() ?? [] as issue}
+						{#each signup.fields.confirmPassword.issues() ?? [] as issue, i (i)}
 							<Field.Error>{issue.message}</Field.Error>
 						{/each}
 					</Field.Field>

frontend/src/lib/components/layout/library-switcher.svelte

@@ -3,7 +3,7 @@
 	import * as Sidebar from '$lib/components/ui/sidebar/index.js';
 	import { useSidebar } from '$lib/components/ui/sidebar/index.js';
 	import { Badge } from '$lib/components/ui/badge/index.js';
-	import { getLibraryState, LibraryState } from '$lib/state/library.svelte';
+	import { getLibraryState } from '$lib/state/library.svelte';
 	import { LIBRARY_ICONS } from '$lib/components/ui/icon-picker/index.js';
 	import ChevronsUpDownIcon from '@lucide/svelte/icons/chevrons-up-down';
 	import PlusIcon from '@lucide/svelte/icons/plus';

frontend/src/lib/components/layout/search-form.svelte

@@ -53,9 +53,9 @@
 		}
 	}
 
-	function handleClick(e: any) {
+	function handleClick(e: Event & { currentTarget: HTMLElement }) {
 		open = true;
-		e.target.blur();
+		e.currentTarget.blur();
 	}
 </script>
 
@@ -93,7 +93,7 @@
 		</div>
 	{:else}
 		<Command.List class="max-h-[600px]">
-			{#if searchResult?.items.length > 0}
+			{#if (searchResult?.items?.length ?? 0) > 0}
 				<Command.Group heading="Books">
 					{#each searchResult?.items as book (book.id)}
 						<Command.Item
@@ -121,7 +121,7 @@
 									{#if book.authors.length > 0}
 										<span class="line-clamp-1 w-full text-sm text-muted-foreground">
 											by
-											{#each book.authors as author}
+											{#each book.authors as author (author.id)}
 												<a
 													href="{resolve('/(root)/(library)/library/[libraryId]/view', {
 														libraryId: String(libraryState.activeLibrary!.id)
@@ -132,7 +132,7 @@
 										</span>
 									{/if}
 									<div class="mt-1 ml-[-1.5] flex">
-										{#each book.tags as tag}
+										{#each book.tags as tag (tag.id)}
 											<Badge class="scale-75">{tag.name}</Badge>
 										{/each}
 									</div>

frontend/src/lib/components/ui/file-drop-zone/file-drop-zone.svelte

@@ -185,7 +185,6 @@
 		type="file"
 		onchange={change}
 		webkitdirectory={directory}
-		{directory}
 		class="hidden"
 	/>
 </label>

frontend/src/lib/components/ui/icon-picker/icon-picker.svelte

@@ -37,7 +37,7 @@
 </script>
 
 <Popover.Root bind:open>
-	<Popover.Trigger asChild>
+	<Popover.Trigger>
 		{#snippet child({ props })}
 			<Button variant="outline" size="icon" class="h-9 w-9" {...props}>
 				<SelectedIconComponent class="size-4" />

frontend/src/lib/components/ui/tags-input/tags-input.svelte

@@ -36,7 +36,6 @@
 
 	$effect(() => {
 		// whenever input value changes reset invalid
-		// eslint-disable-next-line @typescript-eslint/no-unused-expressions
 		inputValue;
 
 		untrack(() => {

frontend/src/lib/components/ui/textarea/textarea.svelte

@@ -19,5 +19,4 @@
 		className
 	)}
 	bind:value
-	{...restProps}
+	{...restProps}></textarea>
-></textarea>

frontend/src/lib/components/view/book-grid.svelte

@@ -4,7 +4,6 @@
 
 	import type { Book } from '$lib/schema';
 	import BookThumbnail from './book-thumbnail.svelte';
-	import { goto } from '$app/navigation';
 	import { getBookSelectionState } from '$lib/state/bookSelection.svelte';
 	import { getBookOperationsState } from '$lib/state/bookOperations.svelte';
 	import { getLibraryState } from '$lib/state/library.svelte';

frontend/src/lib/components/view/book-image.svelte

@@ -1,8 +1,10 @@
 <script>
 	let { src, fallback = '/images/default_cover.jpg', class: className = '' } = $props();
 
-	async function handleError(e) {
+	/** @param {Event} e */
-		e.target.src = fallback;
+	function handleError(e) {
+		const img = /** @type {HTMLImageElement} */ (e.currentTarget);
+		img.src = fallback;
 	}
 </script>
 

frontend/src/lib/components/view/book-table.svelte

@@ -2,7 +2,6 @@
 	import { resolve } from '$app/paths';
 	import * as Table from '$lib/components/ui/table/index';
 	import * as DropdownMenu from '$lib/components/ui/dropdown-menu/index';
-	import * as Tooltip from '$lib/components/ui/tooltip/index';
 	import { Checkbox } from '$lib/components/ui/checkbox/index';
 	import { Badge } from '$lib/components/ui/badge/index';
 	import { buttonVariants } from '$lib/components/ui/button/index.js';

frontend/src/lib/components/view/book-thumbnail.svelte

@@ -2,12 +2,11 @@
 	import { resolve } from '$app/paths';
 	import BookImage from './book-image.svelte';
 	import GeneratedCover from './generated-cover.svelte';
-	import { Progress } from '$lib/components/ui/progress/index';
 	import { getLibraryState } from '$lib/state/library.svelte';
 	import { getBookSelectionState } from '$lib/state/bookSelection.svelte';
 	import type { Book } from '$lib/schema';
 
-	let { book, class: className = '', ...rest }: { book: Book; class?: string } = $props();
+	let { book, class: className = '' }: { book: Book; class?: string } = $props();
 
 	const selectionState = getBookSelectionState();
 	const libraryState = getLibraryState();
@@ -78,7 +77,7 @@
 
 	<!-- Authors list -->
 	<p class="line-clamp-1 w-full text-xs text-muted-foreground">
-		{#each book.authors as author}
+		{#each book.authors as author (author.id)}
 			<a
 				href="{resolve('/(root)/(library)/library/[libraryId]/view', {
 					libraryId: String(libraryState.activeLibrary?.id ?? '')

frontend/src/lib/components/view/filters.svelte

@@ -30,7 +30,7 @@
 			<Collapsible.Content class="h-full max-h-128 overflow-y-auto">
 				<Sidebar.GroupContent>
 					<Sidebar.Menu>
-						{#each filter.items as item, index (item.id)}
+						{#each filter.items as item (item.id)}
 							<Sidebar.MenuItem
 								onclick={() => bookCollection.toggleFilter(filter.value, item.id.toString())}
 							>

frontend/src/lib/components/view/sort-button.svelte

@@ -25,7 +25,7 @@
 					</DropdownMenu.Trigger>
 					<DropdownMenu.Content class="w-40">
 						<DropdownMenu.Group>
-							{#each bookCollection.sortOptions as sortProp}
+							{#each bookCollection.sortOptions as sortProp (sortProp.value)}
 								<DropdownMenu.Item
 									onSelect={() => bookCollection.updateSort(sortProp.value)}
 									class={bookCollection.orderBy === sortProp.value ? 'bg-muted' : ''}

frontend/src/lib/schema/auth.ts

@@ -4,8 +4,6 @@ const emailSchema = z
 	.email('Please enter a valid email address')
 	.max(255, 'Email address cannot exceed 255 characters');
 
-const usernameSchema = z.string().min(1, 'Email is required');
-
 const basePasswordSchema = z.string().min(1, 'Password is required');
 
 const strongPasswordSchema = z.string().min(8, 'Password must be at least 8 characters');

frontend/src/lib/schema/author.ts

@@ -1,7 +1,5 @@
-import { z } from 'zod';
-
 import type { components } from './openapi/schema';
-import { commonQuerySchema, stringArrayCoerce, stringCoerce } from './common';
+import { commonQuerySchema, stringArrayCoerce } from './common';
 
 export type Author = components['schemas']['AuthorRead'];
 

frontend/src/lib/schema/book.ts

@@ -67,7 +67,7 @@ const identifiersSchema = z
 	.transform((str, ctx) => {
 		try {
 			return JSON.parse(str);
-		} catch (e) {
+		} catch {
 			ctx.addIssue({
 				code: 'custom',
 				message: 'Must be a valid JSON string'

frontend/src/lib/schema/publisher.ts

@@ -1,5 +1,3 @@
-import { z } from 'zod';
-
 import type { components } from './openapi/schema';
 import { commonQuerySchema, stringArrayCoerce } from './common';
 

frontend/src/lib/schema/tag.ts

@@ -1,5 +1,3 @@
-import { z } from 'zod';
-
 import type { components } from './openapi/schema';
 import { commonQuerySchema, stringArrayCoerce } from './common';
 

frontend/src/lib/server/api.ts

@@ -21,7 +21,7 @@ export class ApiClient {
 		return this.request(endpoint);
 	}
 
-	async post(endpoint: string, data: any): Promise<Response> {
+	async post(endpoint: string, data: unknown): Promise<Response> {
 		return this.request(endpoint, {
 			method: 'POST',
 			headers: {
@@ -48,7 +48,7 @@ export class ApiClient {
 		});
 	}
 
-	async put(endpoint: string, data: any): Promise<Response> {
+	async put(endpoint: string, data: unknown): Promise<Response> {
 		return this.request(endpoint, {
 			method: 'PUT',
 			headers: {
@@ -71,7 +71,7 @@ export class ApiClient {
 		});
 	}
 
-	async patch(endpoint: string, data: any): Promise<Response> {
+	async patch(endpoint: string, data: unknown): Promise<Response> {
 		return this.request(endpoint, {
 			method: 'PATCH',
 			headers: {

frontend/src/lib/state/bookCollection.svelte.ts

@@ -1,5 +1,5 @@
 import { getContext, setContext } from 'svelte';
-import { goto, pushState, replaceState } from '$app/navigation';
+import { goto, replaceState } from '$app/navigation';
 import type { Book, DynamicFilterData, FilterOption, PaginatedResponse } from '$lib/schema';
 import { page } from '$app/state';
 import { BookOperationsState } from './bookOperations.svelte';
@@ -105,6 +105,7 @@ export class BookCollectionState {
 
 		this.view = next;
 
+		// eslint-disable-next-line svelte/prefer-svelte-reactivity -- local temporary, not reactive state
 		const url = new URL(page.url);
 		url.searchParams.set('view', next);
 		// Not a route to resolve — this is the current URL with one query param
@@ -138,6 +139,7 @@ export class BookCollectionState {
 
 	updateSearchParams() {
 		// Update URL
+		// eslint-disable-next-line svelte/prefer-svelte-reactivity -- local temporary, not reactive state
 		const url = new URL(window.location.href);
 
 		Object.entries(this.filters).forEach(([filter, values]) => {
@@ -215,6 +217,7 @@ export class BookCollectionState {
 		// and skips every page in between.
 		this.currentBookPage = 1;
 
+		// eslint-disable-next-line svelte/prefer-svelte-reactivity -- local temporary, not reactive state
 		const urlParams = new URLSearchParams(window.location.search);
 
 		// Re-read sort and filter state from URL

frontend/src/lib/state/bookOperations.svelte.ts

@@ -16,7 +16,7 @@ export class BookOperationsState {
 	// Delete dialog related state
 	deleteDialogOpen = $state(false);
 	deleteDialogTitle = $state('Delete books?');
-	deleteFn = $state((deleteFiles: boolean) => {});
+	deleteFn = $state((_deleteFiles: boolean) => {});
 
 	// Edit dialog related state
 	editDialogOpen = $state(false);
@@ -131,6 +131,7 @@ export class BookOperationsState {
 
 	async downloadBooks(bookIds: string[] | number[], filename?: string) {
 		// Construct the download URL
+		// eslint-disable-next-line svelte/prefer-svelte-reactivity -- local temporary, not reactive state
 		const downloadUrl = new URL(`/api/books/download`, page.url.origin);
 		downloadUrl.searchParams.set('library_id', this.libraryId);
 		bookIds.forEach((id) => {
@@ -142,6 +143,7 @@ export class BookOperationsState {
 
 	async downloadBookFile(bookId: number, fileId: number, filename: string) {
 		// Construct the download URL
+		// eslint-disable-next-line svelte/prefer-svelte-reactivity -- local temporary, not reactive state
 		const downloadUrl = new URL(`/api/books/download/${bookId}/${fileId}`, page.url.origin);
 		this.download(downloadUrl, filename);
 	}

frontend/src/lib/state/bookshelf.svelte.ts

@@ -1,4 +1,4 @@
-import { goto, invalidate } from '$app/navigation';
+import { invalidate } from '$app/navigation';
 import { addBooksToShelf, createBookshelf, listBookshelves, removeBooksFromShelf } from '$lib/api';
 import type { Book, Bookshelf } from '$lib/schema';
 import { getContext, setContext } from 'svelte';
@@ -22,7 +22,7 @@ export class BookshelfState {
 
 	async fetchBookshelves(libraryId: string) {
 		try {
-			let paginatedBookshelves = await listBookshelves({
+			const paginatedBookshelves = await listBookshelves({
 				libraries: [libraryId]
 			});
 
@@ -34,7 +34,7 @@ export class BookshelfState {
 
 	async addBookshelf(name: string, libraryId?: string | number, booksToAdd?: string[] | number[]) {
 		try {
-			let bookshelf = await createBookshelf({
+			const bookshelf = await createBookshelf({
 				title: name,
 				library_id: libraryId,
 				book_ids: booksToAdd
@@ -116,6 +116,7 @@ export class BookshelfState {
 		if (!bookshelves) return;
 
 		// Create a Set of shelf IDs that need updating for efficient lookup
+		// eslint-disable-next-line svelte/prefer-svelte-reactivity -- local temporary, not reactive state
 		const shelfIdsToUpdate = new Set<number>();
 		books.forEach((book) => {
 			book.lists.forEach((shelf) => {
@@ -132,7 +133,7 @@ export class BookshelfState {
 						decrementBy++;
 					}
 				});
-				return { ...shelf, total: shelf.total - decrementBy };
+				return { ...shelf, total: (shelf.total ?? 0) - decrementBy };
 			}
 			return shelf;
 		});

frontend/src/lib/state/library.svelte.ts

@@ -1,6 +1,6 @@
 import { resolve } from '$app/paths';
 import { browser } from '$app/environment';
-import { goto, invalidate } from '$app/navigation';
+import { goto } from '$app/navigation';
 import { page } from '$app/state';
 import { deleteLibrary } from '$lib/api';
 import type { Library } from '$lib/schema';

frontend/src/routes/(root)/(library)/+layout.svelte

@@ -1,7 +1,7 @@
 <script lang="ts">
 	import BookDelete from '$lib/components/forms/book-delete.svelte';
 	import { BookEdit } from '$lib/components/forms/edit-book';
-	import { getBookOperationsState, setBookOperationsState } from '$lib/state/bookOperations.svelte';
+	import { getBookOperationsState } from '$lib/state/bookOperations.svelte';
 	import { getLibraryState } from '$lib/state/library.svelte';
 	import { setBookSelectionState } from '$lib/state/bookSelection.svelte';
 	import type { Snippet } from 'svelte';

frontend/src/routes/(root)/(library)/book/[bookId]/+page.svelte

@@ -28,22 +28,16 @@
 	import { getBookOperationsState } from '$lib/state/bookOperations.svelte.js';
 	import { getBookshelfState } from '$lib/state/bookshelf.svelte.js';
 	import { getLibraryState } from '$lib/state/library.svelte.js';
-	import { Progress } from '$lib/components/ui/progress/index.js';
 	import * as Accordion from '$lib/components/ui/accordion/index.js';
 	import * as Table from '$lib/components/ui/table/index.js';
 	import * as AlertDialog from '$lib/components/ui/alert-dialog/index.js';
 	import ShelfCreateDialog from '$lib/components/forms/shelf-create-dialog.svelte';
-	import { untrack } from 'svelte';
 
 	let { data } = $props();
 
-	// Seeded once, then kept in sync by the effect below — untrack says so
+	// Follows the loaded book, and stays assignable so an edit can update it locally
-	// explicitly rather than capturing the initial value and warning about it.
+	// until the next navigation supplies a fresh one.
-	let book = $state(untrack(() => data.book));
+	let book = $derived(data.book);
-
-	$effect(() => {
-		book = data.book;
-	});
 
 	const bookOps = getBookOperationsState();
 	const libraryState = getLibraryState();

frontend/src/routes/(root)/(library)/library/[libraryId]/view/+page.svelte

@@ -20,7 +20,13 @@
 		};
 	} = $props();
 
-	const { books, ...filterData } = data;
+	// Seeds the collection state once, deliberately: it owns the list from here on, and the
+	// effect below feeds it later navigations. untrack says so, rather than reading props
+	// outside a closure and being warned about capturing only the initial value.
+	const { books, filterData } = untrack(() => {
+		const { books: initialBooks, ...rest } = data;
+		return { books: initialBooks, filterData: rest };
+	});
 
 	const bookOps = getBookOperationsState();
 	const bookCollection = setBookCollectionState(bookOps, books, filterData);

frontend/src/routes/(root)/+layout.svelte

@@ -1,9 +1,7 @@
 <script lang="ts">
-	import { listBookshelves } from '$lib/api';
 	import AppSidebar from '$lib/components/layout/app-sidebar.svelte';
 	import SiteHeader from '$lib/components/layout/site-header.svelte';
 	import UploadTray from '$lib/components/layout/upload-tray.svelte';
-	import { Loading } from '$lib/components/ui/command';
 	import * as Sidebar from '$lib/components/ui/sidebar/index.js';
 	import type { Library, PaginatedResponse } from '$lib/schema';
 	import { setBookOperationsState } from '$lib/state/bookOperations.svelte';
@@ -28,8 +26,8 @@
 	// init. `untrack` says that explicitly, instead of silently capturing the
 	// initial value and warning about it.
 	const libraryState = setLibraryState(untrack(() => data.libraries.items));
-	const bookshelfState = setBookshelfState();
+	setBookshelfState();
-	const bookOps = setBookOperationsState(libraryState.activeLibrary!.id);
+	setBookOperationsState(libraryState.activeLibrary!.id);
 	const theme = setThemeState(untrack(() => data.theme));
 
 	// Set here rather than beside the upload dialog so a running import survives

frontend/src/routes/(root)/settings/+layout.svelte

@@ -41,7 +41,7 @@
 		     of libraries; the row above it is overflow-hidden, so without this a
 		     long list is clipped rather than reachable. -->
 		<nav class="flex w-48 shrink-0 flex-col gap-1 overflow-y-auto">
-			{#each items as item}
+			{#each items as item (item.routeId)}
 				<a
 					href={resolve(item.routeId)}
 					class="rounded-md px-3 py-2 text-sm font-medium transition-colors hover:bg-muted {page

frontend/src/routes/(root)/settings/+page.ts

@@ -1,8 +1,6 @@
 import { redirect } from '@sveltejs/kit';
 
-export async function load({ parent }) {
+export async function load() {
-	const { libraries } = await parent();
-
 	// Immediately redirect to the account settings
 	redirect(303, `/settings/account`);
 }

frontend/src/routes/(root)/settings/devices/+page.svelte

@@ -21,11 +21,12 @@
 	import { toast } from 'svelte-sonner';
 	import { invalidateAll } from '$app/navigation';
 	import type { Device } from '$lib/schema/device';
+	import { SvelteSet } from 'svelte/reactivity';
 
 	let { data } = $props();
 
 	let createDialogOpen = $state(false);
-	let visibleApiKeys = $state<Set<string>>(new Set());
+	const visibleApiKeys = new SvelteSet<string>();
 	let deleteConfirmDevice = $state<Device | null>(null);
 	let regenerateConfirmDevice = $state<Device | null>(null);
 
@@ -35,7 +36,6 @@
 		} else {
 			visibleApiKeys.add(deviceId);
 		}
-		visibleApiKeys = new Set(visibleApiKeys);
 	}
 
 	function maskApiKey(apiKey: string): string {
@@ -130,7 +130,7 @@
 					</Table.Row>
 				</Table.Header>
 				<Table.Body>
-					{#each data.devices as device}
+					{#each data.devices as device (device.id)}
 						{@const isVisible = visibleApiKeys.has(String(device.id))}
 						<Table.Row class="h-14">
 							<Table.Cell class="pl-4 font-medium">

frontend/src/routes/(root)/settings/libraries/+page.svelte

@@ -31,7 +31,7 @@
 				</Table.Row>
 			</Table.Header>
 			<Table.Body>
-				{#each libraryState.libraries as library}
+				{#each libraryState.libraries as library (library.id)}
 					<Table.Row class="h-14">
 						<Table.Cell class="w-16 pl-4 text-center text-lg font-semibold"
 							>{library.name[0]}</Table.Cell

frontend/src/routes/api/[...path]/+server.ts

@@ -1,7 +1,7 @@
 // src/routes/api/[...path]/+server.ts
 import { BACKEND_API_URL } from '$lib/server/config';
 import { json, error } from '@sveltejs/kit';
-// import type { RequestHandler } from './$types';
+import type { RequestHandler } from './$types';
 
 // Helper function to handle both JSON and file responses
 async function handleResponse(response: Response) {
@@ -137,7 +137,7 @@ export const DELETE: RequestHandler = async ({ params, locals, fetch, request, u
 		const headers = prepareRequest(locals, request);
 
 		// DELETE may or may not have a body
-		let options: RequestInit = {
+		const options: RequestInit = {
 			method: 'DELETE',
 			headers
 		};

frontend/src/routes/login/+page.svelte

@@ -1,9 +1,7 @@
 <script lang="ts">
-	import { replaceState } from '$app/navigation';
 	import LoginForm from '$lib/components/forms/login-form.svelte';
 	import SignupForm from '$lib/components/forms/signup-form.svelte';
 	import * as Tabs from '$lib/components/ui/tabs/index.js';
-	import { redirect } from '@sveltejs/kit';
 
 	let tabValue = $state('login');
 </script>